refactor: remove unused error returns from internal functions #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
refactor/remove-always-nil-errors
branch
2 times, most recently
from
829f302 to
3426941
Compare
erikvarga
approved these changes
Mar 10, 2025
G-Rath
force-pushed
the
refactor/remove-always-nil-errors
branch
from
3426941 to
5667887
Compare
erikvarga
approved these changes
Mar 11, 2025
G-Rath
force-pushed
the
refactor/remove-always-nil-errors
branch
from
5667887 to
1c994fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since none of these functions actually return an error value, we can remove that return entirely and in doing so remove a few error checks that would never be hit.
In the long run the
unparamlinter will help catch this for us.Relates to #274